Skip to content

Retry S3 ExpiredToken write responses - #2

Merged
bill-ph merged 4 commits into
posthog/v1.5.3from
codex/httpfs-expired-token-write-retry
Jun 29, 2026
Merged

Retry S3 ExpiredToken write responses#2
bill-ph merged 4 commits into
posthog/v1.5.3from
codex/httpfs-expired-token-write-retry

Conversation

@bill-ph

@bill-ph bill-ph commented Jun 29, 2026

Copy link
Copy Markdown

Summary

  • retry returned S3 400 ExpiredToken responses through the existing credential refresh path
  • cover write calls that return response bodies instead of throwing, including POST result bodies
  • keep the retry narrow to returned S3 ExpiredToken responses while preserving the existing thrown 400/403 refresh behavior
  • disable persistent secrets in the HTTPFS disabled-filesystem test so it exercises HTTPFS instead of an unrelated local secret-storage init path

Verification

  • git diff --check
  • make release
  • ./build/release/test/unittest "test/sql/settings/test_disabled_file_system_httpfs.test"
  • local red check: temporarily disabled the returned-response retry and confirmed the ExpiredToken write path no longer completed
  • local green check: restored the retry and confirmed the write path completed with refreshed credentials

Note: the exact returned S3 400 ExpiredToken behavior needs a server that can synthesize that S3 response. I removed the custom Python/Shell test harness from this PR because it does not match this repo’s existing test conventions.

@bill-ph
bill-ph merged commit 0dac6fc into posthog/v1.5.3 Jun 29, 2026
26 checks passed
@bill-ph
bill-ph deleted the codex/httpfs-expired-token-write-retry branch June 29, 2026 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant