build(docker): switch runtime images from debian to wolfi-base - #1020
Open
feliperalmeida wants to merge 1 commit into
Open
build(docker): switch runtime images from debian to wolfi-base#1020feliperalmeida wants to merge 1 commit into
feliperalmeida wants to merge 1 commit into
Conversation
Test Impact PlanDeterministic summary of how this PR changes tests, CI runners, and coverage-risk signals. Summary
Signals
Coverage risk: neutral or increased No coverage-reduction warnings detected. |
feliperalmeida
marked this pull request as ready for review
July 30, 2026 18:56
Piccirello
approved these changes
Jul 31, 2026
Piccirello
left a comment
Member
There was a problem hiding this comment.
Security side LGTM but defer to MW for signoff
| ./cmd/duckgres-controlplane | ||
|
|
||
| FROM debian:bookworm-slim | ||
| FROM chainguard/wolfi-base:latest |
Member
There was a problem hiding this comment.
Is there any risk in moving from a specific version of debian to unpinned wolfi version?
Author
There was a problem hiding this comment.
I thought about that for a bit, and ended up concluding that wolfi-base is such a small image (basically OS + glibc + apk + bash) that seemed ok to use latest - they provide sha tags for reproducible builds if that's something we'd look for, but I don't think that should be needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switches the runtime stage of all three images (
Dockerfile,Dockerfile.controlplane,Dockerfile.worker) fromdebian:bookworm-slimtochainguard/wolfi-base. Builder stages are unchanged.postgresql-18-clientnatively, so the wget/gnupg/apt-repo dance for the reshard runner'spg_dump/pg_restoreis gone (pin to PG 18 preserved).libstdc++added explicitly where the CGO-linked DuckDB engine needs it (Dockerfile,Dockerfile.worker) — debian-slim shipped it implicitly, wolfi-base doesn't. Deliberately omitted from the CP image, which doesn't link libduckdb.duckgresuser now created via busyboxaddgroup/adduser.Verified locally: all-in-one serves psql over TLS with DDL/DML + JSON-extension queries; worker pre-warms DuckDB and loads the bundled ducklake extension; CP binary runs with
pg_dump18.4 present; all run as non-root on Wolfi.🤖 Generated with Claude Code