Merge upstream duckdb/ducklake main into PostHog fork - #23
Open
jghoman wants to merge 243 commits into
Open
Conversation
…er-change-in-txn Fix drop table/view after change in txn
Fix sort SQL with quoted columns
Allow compaction to finish without an output file when the source files have zero live rows. This lets merge_adjacent_files compact zero-row parquet files without tripping the single-output-file assertion while still rejecting missing output for non-empty input. Fixes duckdb#525
…y-files Fix merge_adjacent_files with empty source files
…in-txn Fix ducklake stats for columns with default
Fix quote processing for macros
…ename Fix view rename but comment dropped
Per review feedback: comments recounting what was wrong before the fix (the old local-index behavior, the mis-attributed snapshots, the wrong-snapshot symptom) add no information for readers without that context. Rewrite them to describe what the current code does and what each test asserts, keeping the explanation that output positions come from global_column_ids. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Fix SET NOT NULL with deleted NULL rows
…napshot-projection-order fix: correct delete snapshot_id under virtual-column projection reordering (duckdb#1199)
Fix ducklake scan serialization for window partition
Server-side transaction retrial for Quack
…che-eviction Evict DuckLake schema cache on snapshot expiration
…he-entry-estimated-size Improve schema cache entry estimated size
Merge V1.5 -> Main
Brings in 242 upstream commits, dominated by PR duckdb#1216 ("Merge V1.5 -> Main") which folded ~6 weeks of v1.5-variegata work into upstream main on 2026-06-09. The most important contents for this fork: - PR duckdb#1150's TableFilter/ExpressionFilter rename and related OPTIONAL_FILTER -> LEGACY_OPTIONAL_FILTER / OptionalFilter -> optional_ptr API drift fixes, which were the cause of every red C++ test workflow on our main since 2026-05-09. - Server-side commit / ducklake_commit refactor. - Quack catalog integration scaffolding. - v1.5.3 release prep and assorted dentiny bug fixes. - duckdb submodule + .github/duckdb-version moved off "main" to a pinned SHA (a1b15369), so CI is no longer a moving target. Conflict resolution (one file, two hunks): .github/workflows/MainDistributionPipeline.yml - duckdb-next-build "uses:" — kept HEAD's vendored copy (./.github/workflows/_extension_distribution.yml). Upstream switched to @v1.5-variegata; we still vendor to satisfy the PostHog org SHA-pin policy. Comment updated to record this. - publish-github-release job — kept HEAD verbatim. This is our PR #4 binary-publish job; upstream has no equivalent. Local verification: just build -> 748/748, no errors just test -> 441 test cases, 15,753 assertions, all passing (18 skipped: httpfs / postgres_scanner / sqlite_scanner / spatial / DUCKLAKE_CI env)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Brings in 242 upstream commits — dominated by upstream PR #1216 ("Merge V1.5 → Main"), which folded ~6 weeks of
v1.5-variegatawork into upstreammainon 2026-06-09.Why this PR exists
Every C++ test workflow on our
mainhas been red since 2026-05-09 with build errors against current DuckDB API:TableFilter::Copynot a memberOPTIONAL_FILTERis not a member ofTableFilterType(renamed toLEGACY_OPTIONAL_FILTER)OptionalFilternot declared (replaced byoptional_ptr)TableFilter::Cast<...>overload mismatchAll four are fixed by upstream PR #1150 and surrounding
v1.5-variegatawork, which this merge brings in.Notable upstream content (beyond the build fix)
ducklake_commitrefactorduckdbsubmodule +.github/duckdb-versionmoved offmainto a pinned SHA (a1b15369), so CI is no longer a moving targetConflict resolution
One file, two hunks —
.github/workflows/MainDistributionPipeline.yml:duckdb-next-builduses:reference./.github/workflows/_extension_distribution.yml). Upstream switched to@v1.5-variegata; we still vendor to satisfy the PostHog org SHA-pin policy. Comment updated to record this.publish-github-releasejobLocal verification
just buildjust testDUCKLAKE_CIenv)Test plan
just testagain after merge to main