fix(ci): eliminate build warnings - #664
Conversation
|
| api(project(":posthog")) | ||
|
|
||
| implementation(kotlin("stdlib-jdk8", PosthogBuildConfig.Kotlin.KOTLIN)) | ||
| api(kotlin("stdlib-jdk8", PosthogBuildConfig.Kotlin.KOTLIN)) |
There was a problem hiding this comment.
posthog-server exposes Kotlin @deprecated(..., level = DeprecationLevel.WARNING) annotations in its public API. With
stdlib declared as implementation, Kotlin annotation classes aren’t available on a Java consumer’s compile classpath.
Changing it to api:
- does not bundle another stdlib into the SDK;
- exposes the dependency transitively at compile time;
- still lets Gradle resolve against the host’s explicitly declared stdlib version.
posthog-android Compliance ReportDate: 2026-07-29 08:11:27 UTC ✅ All Tests Passed!46/46 tests passed Capture Tests✅ 29/29 tests passed View Details
Feature_Flags Tests✅ 17/17 tests passed View Details
|
|
Reviews (1): Last reviewed commit: "chore: defer changeset for warning clean..." | Re-trigger Greptile |
💡 Motivation and Context
PR #661 passed, but its CI logs contained several deprecation and compiler warnings that made real failures harder to spot and would block future Gradle upgrades.
This change removes those warnings by:
posthog-servercompile classpath for Java consumersevaluateFlags💚 How did you test it?
JAVA_HOME=$HOME/.sdkman/candidates/java/17.0.18-amzn make updateLocksmake checkFormat./gradlew :posthog:check :posthog-server:check :posthog-android:check --write-locks --warning-mode all-Xlint:deprecation📝 Checklist
If releasing new changes
pnpm changesetto generate a changeset file🤖 Agent context
Autonomy: Human-driven (agent-assisted)
Implemented with the Pi coding agent after a human-directed review of every CI log from PR #661. AnimalSniffer 2.x newly registers Android variant checks that the previous version did not; those targets remain disabled because Android lint owns API compatibility, while JVM main, test, and test-fixture checks remain enabled. The full JDK 17 build and targeted warning-mode/compiler checks were run before submission. The agent session was not shared publicly.