fix: textfield masking and element transform positioning in session replay#305
Open
fix: textfield masking and element transform positioning in session replay#305
Conversation
marandaneto
reviewed
Feb 24, 2026
| @override | ||
| Rect? buildElementRect(Element element, Rect? parentRect) { | ||
| final RenderImage renderImage = element.renderObject as RenderImage; | ||
| ({Rect rect, Matrix4 transform})? buildElementData(Element element) { |
Member
There was a problem hiding this comment.
use a typedef or a data class to the return type so you dont have to repeat this and its self documented
marandaneto
reviewed
Feb 24, 2026
|
|
||
| for (var elementData in items) { | ||
| paint.color = Colors.black; | ||
| if (elementData.widget is PostHogMaskWidget) { |
Member
There was a problem hiding this comment.
why don we check this anymore?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
Closes #239
Fixes mask positioning for TextFields and elements under transforms (e.g. ScreenUtil scaling, rotations).
💚 How did you test it?
📝 Checklist
If releasing new changes
pnpm changesetto generate a changeset filereleaselabel to the PR