feat(tasks): widen send_followup_message signal handler arity - #71562
Merged
Conversation
Contributor
|
Reviews (1): Last reviewed commit: "feat(tasks): widen send_followup_message..." | Re-trigger Greptile |
Member
Author
Accept the full per-message positional arg list (message_id, actor_user_id, message_context) with defaults, ahead of the callers that populate it. Temporal delivers every positional arg a caller sends to the handler, so a handler declaring fewer params than were sent fails the workflow task. Deploying this widened handler to all workers first lets the follow-up queue and actor changes send the richer signal without breaking in-flight workflows during rollout.
VojtechBartos
force-pushed
the
vojtab/slack-followup-signal-handler
branch
from
July 17, 2026 10:08
129a602 to
da75016
Compare
cvolzer3
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Temporal delivers every positional arg a caller sends straight to the signal handler, and a handler declaring fewer params than were sent raises and fails the workflow task. The follow-up queue stack widens
send_followup_messagefrom 2 args to 5 (message_id,actor_user_id,message_context). If a new sender reaches an old worker mid-rollout, that workflow gets stuck until the worker upgrades.Change
Widen the handler signature to the full 5-param arg list now, with defaults and the body unchanged (the extra fields are accepted and ignored here). Deploying this to every worker first makes them tolerant of both the old and new call shapes, so the senders in the rest of the stack can ship safely.
Deploy this first and let it fully roll out before the sender changes (#70806 → #70762) deploy.
How did you test this code?
Signature-only change, body identical to before; existing follow-up signal tests pass. Base of the follow-up queue stack.
Automatic notifications