feat(cymbal): set posthog-flutter wire-order cutoff - #72962
Conversation
|
Reviews (1): Last reviewed commit: "feat(cymbal): set posthog-flutter wire-o..." | Re-trigger Greptile |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cff325d6d6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Note 🤖 stamphog reviewed Codex flagged an unresolved, substantive concern that this cutoff can cause existing legacy Flutter issues to lose their legacy fingerprint and split into new issues after resolution reshapes frames — the diff doesn't address it.
Gate mechanics and policy version
|
Problem
posthog-flutterpayloads are currently normalized as legacy crash-first stacks at every version. PostHog/posthog-flutter#467 will make Flutter's Dart path canonical and raise the Android SDK floor to3.56.0, whose shared throwable coercer is also canonical. Apple-native exceptions are already canonical.Cymbal must stop reversing events from that Flutter release onward while preserving legacy fingerprint lookup for older issues.
Changes
posthog-flutter'scanonical_sincecutoff to5.33.0Rollout
5.33.0is still the next unclaimed Flutter minor immediately before merge. feat(surveys): add displaySurvey to show a survey on demand posthog-flutter#495 also carries a minor changeset; if it releases first, update this cutoff and feat: emit error-tracking stack frames in canonical bottom-up order posthog-flutter#467 to5.34.0.Known limitation: already-published Flutter
5.32.1accepts the dynamic Android range[3.55.0,4.0.0), so some fresh builds can resolve canonical Android3.56.0while still reporting Flutter5.32.1. A Flutter-version cutoff cannot distinguish those builds. The new Flutter release raises the lower bound and establishes a reliable boundary going forward.Tests
cargo fmt --all --checkcargo test -p cymbal modes::processing::normalization::test::android_server_and_flutter_cutoffs_gate_normalization_by_version --lib