Skip to content

feat(cymbal): set posthog-flutter wire-order cutoff - #72962

Merged
cat-ph merged 1 commit into
masterfrom
cat/cymbal-flutter-cutoff
Jul 23, 2026
Merged

feat(cymbal): set posthog-flutter wire-order cutoff#72962
cat-ph merged 1 commit into
masterfrom
cat/cymbal-flutter-cutoff

Conversation

@cat-ph

@cat-ph cat-ph commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Problem

posthog-flutter payloads are currently normalized as legacy crash-first stacks at every version. PostHog/posthog-flutter#467 will make Flutter's Dart path canonical and raise the Android SDK floor to 3.56.0, whose shared throwable coercer is also canonical. Apple-native exceptions are already canonical.

Cymbal must stop reversing events from that Flutter release onward while preserving legacy fingerprint lookup for older issues.

Changes

  • set posthog-flutter's canonical_since cutoff to 5.33.0
  • cover the version boundary in the existing Android/server cutoff regression test
  • keep reverse-order legacy fingerprint reconstruction after the cutoff

Rollout

Known limitation: already-published Flutter 5.32.1 accepts the dynamic Android range [3.55.0,4.0.0), so some fresh builds can resolve canonical Android 3.56.0 while still reporting Flutter 5.32.1. A Flutter-version cutoff cannot distinguish those builds. The new Flutter release raises the lower bound and establishes a reliable boundary going forward.

Tests

  • cargo fmt --all --check
  • cargo test -p cymbal modes::processing::normalization::test::android_server_and_flutter_cutoffs_gate_normalization_by_version --lib

@greptile-apps

greptile-apps Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Reviews (1): Last reviewed commit: "feat(cymbal): set posthog-flutter wire-o..." | Re-trigger Greptile

@cat-ph cat-ph added the stamphog Request AI approval (no full review) label Jul 22, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: cff325d6d6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread rust/cymbal/src/modes/processing/normalization.rs
@stamphog

stamphog Bot commented Jul 22, 2026

Copy link
Copy Markdown

Note

🤖 stamphog reviewed cff325d6d6393c050119b4a8bd66a1d6f8e35a45 — verdict: REFUSED

Codex flagged an unresolved, substantive concern that this cutoff can cause existing legacy Flutter issues to lose their legacy fingerprint and split into new issues after resolution reshapes frames — the diff doesn't address it.

  • Author wrote 100% of the modified lines and has 15 merged PRs in these paths (familiarity STRONG).
  • chatgpt-codex-connector[bot] reviewed the current head.
  • Unresolved inline comment from @chatgpt-codex-connector on rust/cymbal/src/modes/processing/normalization.rs: raises a real grouping/data-correctness concern (legacy fingerprint reconstruction breaking for pre-cutoff Flutter issues) that the diff does not address.
Gate mechanics and policy version
Gate Result
prerequisites all clear
deny-list no deny categories matched
size 10L, 1F substantive — within ceiling
tier T1-agent / T1a-trivial (10L, 1F, single-area, feat)
stamphog 2.0.0b3 .stamphog/policy.yml @ 8fd209c · reviewed head cff325d

@stamphog stamphog Bot removed the stamphog Request AI approval (no full review) label Jul 22, 2026
@cat-ph
cat-ph merged commit 2ae1d7e into master Jul 23, 2026
406 of 407 checks passed
@cat-ph
cat-ph deleted the cat/cymbal-flutter-cutoff branch July 23, 2026 16:21
@deployment-status-posthog

deployment-status-posthog Bot commented Jul 23, 2026

Copy link
Copy Markdown

Deploy status

Environment Status Deployed At Workflow
dev ✅ Deployed 2026-07-23 17:10 UTC Run
prod-us ✅ Deployed 2026-07-23 17:30 UTC Run
prod-eu ✅ Deployed 2026-07-23 17:31 UTC Run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants