fix(live): offer simulator practice alongside text assessment - #252
Merged
Merged
Conversation
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ordinary compiled concepts include both text and simulator criteria. The previous selection rule rejected these concepts for generation and never mounted their approved instruments. This change makes verified simulator practice available alongside the existing text assessment, as requested.
The turn persists the practice descriptor separately, preserving the original grading criterion and assessment surface. The factory prepares the simulator criterion independently; gestures retain active-turn validation and replay protection and never award mastery. Retrieval excludes practice. The UI reuses the authenticated sandbox and shared-state tutor bridge, with preparation and failure feedback that leaves text assessment usable.
Validation: full Python and web suites passed; focused API tests cover mixed and sim-only variants, unchanged mastery, explicit assessment grading, invalid/stale/replayed gestures, ownership, closure and due retrieval. Authenticated Chromium covers keyboard interaction, reload, fresh learner state, revocation and navigation containment for both variants. Python, test and style/UI reviews approved; Ruff, TypeScript, ESLint and formatting pass (one pre-existing fast-refresh warning).
Refs #251, #237, #219. #251 remains open until the gated production release verifies an ordinary compiled course.