Skip to content

Fix AdvancedLivePortrait node parameter order and syntax error#101

Open
sheepbooy wants to merge 1 commit intoPowerHouseMan:mainfrom
sheepbooy:main
Open

Fix AdvancedLivePortrait node parameter order and syntax error#101
sheepbooy wants to merge 1 commit intoPowerHouseMan:mainfrom
sheepbooy:main

Conversation

@sheepbooy
Copy link
Copy Markdown

Problem Description

  • AdvancedLivePortrait node missing tracking_src_vid and animate_without_vid options
  • Syntax error in PrintExpData class name

Changes Made

  1. Fixed parameter order issue:

    • Adjusted the parameter order in AdvancedLivePortrait class run method to match the INPUT_TYPES definition
    • This resolves the issue where tracking_src_vid and animate_without_vid options were not displaying
  2. Fixed syntax error:

    • Removed extra colon from PrintExpData class name in NODE_CLASS_MAPPINGS

Technical Details

The issue was caused by a mismatch between the parameter order in the run method and the INPUT_TYPES definition. ComfyUI requires these to be in exact order for proper parameter mapping.

Before:

def run(self, retargeting_eyes, retargeting_mouth, turn_on, tracking_src_vid, animate_without_vid, command, crop_factor, ...)

After:

def run(self, retargeting_eyes, retargeting_mouth, crop_factor, turn_on, tracking_src_vid, animate_without_vid, command, ...)

Testing

  • After the fix, AdvancedLivePortrait node now correctly displays all 7 parameter options
  • Including the previously missing tracking_src_vid and animate_without_vid options
  • No breaking changes to existing functionality

Impact

  • This is a bug fix that improves user experience
  • Maintains backward compatibility
  • No existing workflows will be affected

- Fix run method parameter order to match INPUT_TYPES definition
- This resolves missing tracking_src_vid and animate_without_vid options
- Fix PrintExpData syntax error (remove extra colon)
- Ensures proper parameter mapping between UI and backend
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant