fix: PrintExpData node crashes with AttributeError on ExpressionSet#106
Open
deepme987 wants to merge 1 commit intoPowerHouseMan:mainfrom
Open
fix: PrintExpData node crashes with AttributeError on ExpressionSet#106deepme987 wants to merge 1 commit intoPowerHouseMan:mainfrom
deepme987 wants to merge 1 commit intoPowerHouseMan:mainfrom
Conversation
The `PrintExpData` node crashes with `AttributeError: 'ExpressionSet' object has no attribute 'exp'` because it references `exp.exp` instead of the correct attribute `exp.e`. The `ExpressionSet` class defines its expression tensor as `.e` (along with `.r`, `.s`, `.t`), and all other nodes (`ExpData`, `ExpressionEditor`, etc.) correctly use `.e`. This was a typo in `PrintExpData.run()` only. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
The
PrintExpDatanode is completely broken — it crashes immediately with:Steps to Reproduce
ExpDatanode with any non-zero valuesPrintExpData:nodeRoot Cause
In
nodes.pyline 634,PrintExpData.run()referencesexp.exp:But the
ExpressionSetclass (line 475) defines its attributes as.e,.r,.s,.t— there is no.expattribute:All other nodes (
ExpData,ExpressionEditor,AdvancedLivePortrait) correctly use.e. This is a typo inPrintExpDataonly.Fix
One-line change:
exp.exp→exp.eTested
Verified the fix locally on ComfyUI 0.14.1 with Python 3.12, PyTorch 2.10+cu130, RTX 4090. The
PrintExpData:node now correctly prints expression data without crashing.Environment