This repository was archived by the owner on Jun 14, 2024. It is now read-only.
Group: fix error if Iis apppool is in local group members#170
Open
machgo wants to merge 3 commits intoPowerShell:devfrom
Open
Group: fix error if Iis apppool is in local group members#170machgo wants to merge 3 commits intoPowerShell:devfrom
machgo wants to merge 3 commits intoPowerShell:devfrom
Conversation
gaelcolas
reviewed
Sep 6, 2019
gaelcolas
left a comment
There was a problem hiding this comment.
Hi, as per other comment, it'd be wise to submit that change to xPSDesiredStateConfiguration.
While I check if the fix should be merged in, could you update the tests to go along with your change please?
https://github.com/PowerShell/PSDscResources/blob/dev/Tests/Unit/MSFT_GroupResource.Tests.ps1#L298-L312
Thanks
Reviewable status: 0 of 2 files reviewed, all discussions resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This PR fixes an error, which occures if the local group has a member with the following format "IIS APPPOOL\xxx". The same problem was already fixed for "NT AUTHORITY\xxx" in dsccommunity/xPSDesiredStateConfiguration#314
This Pull Request (PR) fixes the following issues
none
Task list
Entry should say what was changed, and how that affects users (if applicable).
and comment-based help.
This change is