Repository navigation
feat(core): add generic signed request builder for authenticated API … - #27
Merged
Merged
Conversation
…requests - Implement SignedRequestBuilder with fluent API for parameter building - Add SigningStrategy trait for exchange-specific authentication logic - Create HasHttpClient trait for HTTP client access across exchanges - Add Binance signing strategy implementation with HMAC-SHA256 - Include support for GET/POST/PUT/DELETE methods with proper body handling - Add query string building with URL encoding and alphabetical parameter ordering - Integrate with existing Binance and OKX exchange implementations - Add comprehensive test coverage for signing functionality
…tting improvements - Change base_url return type from &str to &'static str for better lifetime management - Import Map from serde_json for explicit object creation - Update param method to accept reference for ToString trait - Replace string concatenation with format macros for better performance - Use Map::default() instead of Default::default() for serde_json objects - Modernize string formatting with positional arguments in format macros
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…requests