fix: make oracle fallback path panic-free and event-emitting#565
Merged
greatest0fallt1me merged 2 commits intoMay 27, 2026
Merged
Conversation
|
@Agbasimere Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #544
This hardens the graceful degradation fallback path so oracle backup failures never panic mid-resolution.
What changed
OracleBackup::get_pricereturn typed contract errors when both primary and backup failhandle_oracle_timeoutto record degraded status and emit a degradation eventWhy
The fallback path is the safety net when the primary oracle is unavailable. If that path panics or aborts, a market can get stuck during resolution. This change makes the path degrade gracefully instead:
Error::FallbackOracleUnavailableFiles changed
contracts/predictify-hybrid/src/graceful_degradation.rscontracts/predictify-hybrid/src/lib.rsTests