feat: bound recovery history and add admin prune#567
Merged
greatest0fallt1me merged 2 commits intoMay 27, 2026
Merged
Conversation
|
@Dopezapha Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #556
Summary
This PR addresses Issue #556 by introducing an upper bound on retained recovery history records per market and providing an admin-gated prune entrypoint in the Predictify Hybrid Soroban contract. These improvements bound persistent storage growth and prevent high ledger rent costs over time from repeated emergency recovery actions.
Requirements & Solutions Implemented
MAX_RECOVERY_HISTORY_PER_MARKET = 100. History is automatically capped and trimmed when a resolved state is saved.recovery_recordsandrecovery_historyrespectively. An automatic migration (ensure_migrated) was introduced for backward compatibility.prune_recovery_historyexposed inlib.rsand executed viaRecoveryStorage::prune_history. It enforces administrative authorization (admin.require_auth()) and restricts batch operations toMAX_RECOVERY_PRUNE_BATCH = 30for gas safety.Core Changes
contracts/predictify-hybrid/src/recovery.rs:MAX_RECOVERY_HISTORY_PER_MARKET,MAX_RECOVERY_PRUNE_BATCH).ensure_migratedfor seamless backward compatibility.save()to store completed/resolved entries in the bounded history map and unresolved items in the active map.prune_historyfunction containing authority and batch bounds logic.contracts/predictify-hybrid/src/lib.rs:prune_recovery_historyas a public admin entrypoint.Verification & Testing
Added isolated unit tests to fully validate functionality:
test_recovery_history_capped_per_market: Confirms completed history truncates to exactly 100 entries.test_prune_preserves_active_recovery: Assures that active unresolved recovery records remain intact after completed history pruning.test_prune_count_greater_than_stored: Validates safe degradation when requested prune count exceeds stored history length.test_prune_requires_admin: Confirms that unauthorized or non-admin attempts are rejected withError::Unauthorized.