Conversation
jlowin
added
the
enhancement
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR renames the function get_starlette_request to get_http_request in the server context module to better reflect its purpose.
- Renamed the function from get_starlette_request to get_http_request.
- Updated the method signature accordingly.
Files not reviewed (1)
- docs/servers/context.mdx: Language not supported
Comments suppressed due to low confidence (1)
src/fastmcp/server/context.py:231
- The docstring still references 'starlette request' while the function has been renamed to get_http_request. It may be clearer to update the docstring to reflect the new name or intended abstraction.
"""Get the active starlette request."""
jordicore
pushed a commit
to jordicore/fastmcp
that referenced
this pull request
Jul 2, 2025
get_starlette_request → get_http_request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fast follow to rename new method in #302