Skip to content

Remove patch and use upstream SSEServerTransport - #425

Merged
jlowin merged 4 commits into
mainfrom
sse-bugfix
May 16, 2025
Merged

Remove patch and use upstream SSEServerTransport#425
jlowin merged 4 commits into
mainfrom
sse-bugfix

Conversation

@jlowin

@jlowin jlowin commented May 12, 2025

Copy link
Copy Markdown
Member

With modelcontextprotocol/python-sdk#659 merged, we can remove the patched transport and depend on the upstream again. This PR's tests will not pass until mcp 1.8.2 is released.

Copilot AI review requested due to automatic review settings May 12, 2025 20:34

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the custom patched SSE server transport in favor of the upstream implementation from mcp and updates the dependency accordingly.

  • Removed the custom patched SSE server transport (src/fastmcp/low_level/sse_server_transport.py)
  • Updated the import in src/fastmcp/server/http.py to use the upstream transport
  • Bumped the mcp dependency version to 1.8.1 in pyproject.toml

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/fastmcp/server/http.py Updated to import the upstream SSEServerTransport
src/fastmcp/low_level/sse_server_transport.py Removed the custom patched transport implementation
pyproject.toml Updated mcp dependency version to ensure compatibility with the upstream transport

@JonZeolla

JonZeolla commented May 16, 2025

Copy link
Copy Markdown
Contributor

FYI this (modelcontextprotocol/python-sdk@1cb7407) was released in v1.9.0

@jlowin

jlowin commented May 16, 2025

Copy link
Copy Markdown
Member Author

Thank you @JonZeolla!

@jlowin
jlowin merged commit 3e4577e into main May 16, 2025
@jlowin
jlowin deleted the sse-bugfix branch May 16, 2025 01:39
@jlowin jlowin added the bug Something isn't working. Reports of errors, unexpected behavior, or broken functionality. label May 16, 2025
jordicore pushed a commit to jordicore/fastmcp that referenced this pull request Jul 2, 2025
Remove patch and use upstream SSEServerTransport
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working. Reports of errors, unexpected behavior, or broken functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants