Apply per-call maxRetries on top of the client's retry policy - #2
Merged
garretpremo merged 2 commits intoSep 19, 2026
Merged
Conversation
RequestOptions.Builder.maxRetries(n) documented itself as "the client's policy with a different retry count", but it replaced the policy with RetryPolicy.DEFAULT.withMaxRetries(n). A client configured with custom retryable statuses or backoff silently fell back to the defaults for that call, e.g. retrying a 500 with 500 ms backoff when the client only retries 503 with 1 ms backoff. RequestOptions now carries the retry count separately and applies it to the call's retryPolicy when set, otherwise to the client's. This matches the JavaScript SDK, where partial per-call retry overrides inherit unset fields from the client. The previous three-argument constructor is kept.
garretpremo
approved these changes
Sep 19, 2026
garretpremo
added a commit
that referenced
this pull request
Sep 19, 2026
A response missing an answer, an answer field, or answering with a different type than asked now fails systemOne with a TypeSafeException instead of reading as zero or surfacing later (#1, #3). RequestOptions.maxRetries applies on top of the client's policy instead of replacing it with the default (#2). READMEs point at 0.2.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RequestOptions.maxRetries(n) is documented as "the client's policy with a different retry count", but it uses
RetryPolicy.DEFAULT.withMaxRetries(n), so the client's own statuses and backoff are lost for that call. Example: a client that only retries 503, a server returning 500, andmaxRetries(2)→ 3 requests instead of 1.Change:
RequestOptionsnow storesmaxRetriesseparately and applies it on top of the call's policy, or the client's if none is set. The old 3-arg constructor is kept, so existing code still compiles.Test:
perCallMaxRetriesKeepsTheRestOfTheClientPolicy. It fails onmainand passes with the change;./gradlew buildpasses.