feat(ui): split security ranking into research + fix credits#239
Merged
Progi1984 merged 1 commit intoJul 8, 2026
Merged
Conversation
Both the compact Top card and the Wall of Fame Security tab now show three numeric columns instead of one: Advisories · Research · Fixes Advisories is still the total (sort key, unchanged). Research and Fixes come from the new `research` and `remediation` fields in top_security.json (produced by traces:generate:topsecurity). Rationale: fixing a PrestaShop CVE lives entirely in the private security repository and never surfaces on a public PR — so the remediation credit on published advisories is the only structured signal for that work, and hiding it behind a single total defeats the purpose of the board (community thread with Clotaire: prioritise the patchers, not just the reporters). TopRankingView gets an optional `extraColumns` prop so other cards stay single-column. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Contributor
Author
Progi1984
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Why
Follow-up to #237. After discussion with the security team, the split between the two kinds of credited work is worth showing everywhere, not only in the Wall of Fame — because that's the whole point of the board:
Hiding that behind a single total defeats the purpose. Both views now show the breakdown.
What this does
Both the compact Top card in the Top section and the Wall of Fame Security tab now display three numeric columns:
Advisories · Research · Fixes
finder/reporter/analyst/coordinatorcredit.remediation_developer/reviewer/verifiercredit.Fed by the new
researchandremediationfields ontop_security.json.TopRankingViewgets an optionalextraColumnsprop so the other cards (Reviewers / Issues / PR authors) stay single-column and untouched.Card title stays neutral ("🛡️ Top security contributors") — the split does the talking.
Depends on the traces PR: PrestaShop/traces#236. The
top_security.jsonpublished by the current traces release (v6.4.0) only carriescount; the front columns will render-until a new traces release is published including #236. Suggested order:Checks
vitestgreen (12/12), including new coverage for the extra-columns rendering.🤖 Generated with Claude Code