Skip to content

Skip meta pages whose route requires mandatory parameters in sitemap #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
boo-code wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Skip meta pages whose route requires mandatory parameters in sitemap #196

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion gsitemap.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -481,7 +481,15 @@ protected function getMetaLink(&$link_sitemap, $lang, &$index, &$i, $id_meta = 0

$url = '';
if (!in_array($meta['id_meta'], explode(',', Configuration::get('GSITEMAP_DISABLE_LINKS')))) {
$url = $link->getPageLink($meta['page'], null, $lang['id_lang']);
try {
$url = $link->getPageLink($meta['page'], null, $lang['id_lang']);
} catch (PrestaShopException $e) {
// Some meta pages map to routes that require mandatory parameters
// (e.g. a module search route needing an id). Such routes cannot be
// represented in a sitemap without a specific value, so we skip them
// instead of aborting the whole sitemap generation.
continue;
}

if (!$this->addLinkToSitemap($link_sitemap, [
'type' => 'meta',
Expand Down