Skip to content

Specify the PHP warning #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LouiseBonnard wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Specify the PHP warning #173

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5540db5
Specify the PHP warning
LouiseBonnard Nov 13, 2020
d012c34
Update specifications
LouiseBonnard Nov 13, 2020
a829373
Add success notification
LouiseBonnard Nov 20, 2020
5634ceb
Add multistore behavior
LouiseBonnard Nov 20, 2020
e3f041d
Fix typo
LouiseBonnard Nov 20, 2020
bcab118
Update back-office/dashboard.md
marionf Mar 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions back-office/dashboard.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
# **SPECIFICATIONS - DASHBOARD PAGE**


_As a user, I want to know when my PHP version is not suitable - no longer supported or not yet supported._

@MatShir MatShir Mar 12, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
_As a user, I want to know when my PHP version is not suitable - no longer supported or not yet supported._
_As a user, I want to know when my PHP version is not suitable - no longer supported or not yet supported._
If the PHP version matches the PHP compatibility of PrestaShop: no warning message is displayed.
If the PHP version doesn't match the PHP compatibility of PrestaShop: a warning message is displayed. The warning message is the same for inferior or superior not supported version.


Since 1.7.8, a yellow warning notification is displayed on the top of the Dashboard page when the PHP version detected is no longer supported, cf. issue #[20862](https://github.com/PrestaShop/PrestaShop/issues/20862).

It says `You are using a PHP version that is not supported and this can affect your store. Please check PHP requirements and change for the suitable PHP version.` in `Admin.Notifications.Warning`.

Users should be able to dismiss this warning notification when it pops up, but it will keep on appearing at each session until the PHP version is changed.
Comment thread
LouiseBonnard marked this conversation as resolved.

Using the multistore feature, the scenario is expected to be different from one shop to the other: the **notification is dismissed only for the selected context** and should not be redisplayed if the user refreshes or returns to the Dashboard page.

Expected behavior: if the user dismisses the warning notification for Shop 1, it should still be visible in Shop 2.

If, following this recommendation, the user updates the PHP version to use a supported one, when logging in again, he/she should be able to see a green success notification: `You are now running a supported PHP version.` in `Admin.Notifications.Success`.

[TO BE COMPLETED]