Skip to content

Update catalog-products-add-edit.md - #180

Open
MatShir wants to merge 11 commits into
masterfrom
Fix-Robin-comments
Open

Update catalog-products-add-edit.md#180
MatShir wants to merge 11 commits into
masterfrom
Fix-Robin-comments

Conversation

@MatShir

@MatShir MatShir commented Nov 19, 2020

Copy link
Copy Markdown
Contributor
Questions Answers
Description? Missing parts on the specs
Fixed ticket? Remarks on Product specs #171

Product list : When the quantity of a product is at 0 or negative, it's displayed on a red background
Duplicate
@MatShir

MatShir commented Nov 19, 2020

Copy link
Copy Markdown
Contributor Author

@Robin-Fischer-PS noticed that the quantity (product quantity, quantity of the combination), the stock location are not duplicated. Besides these fields, everything is duplicated from the product.

Is the stock was not duplicated on purpose?

At first, I was we would duplicate all but then I thought except for freshly created product the quantity will never be the same. And with the stock page, it is quite easy to update the stock, so I'm kind of thinking not to duplicate the quantity values.
WdYT @marionf @LouiseBonnard

@MatShir MatShir added the WIP Work in progress label Nov 19, 2020
@marionf

marionf commented Nov 23, 2020

Copy link
Copy Markdown
Contributor

the quantity will never be the same

I am not sure of that, I think the use of the duplication is different for each merchant, or even different for each use for a same merchant. We can't predict if they will need to change the quantity or not.
Let's say I receive 2 new products with 100 pieces for each: 1 red and 1 black t-shirt.
I can create the red product and then duplicate it and just change the title, the description and the image.
I think when you click on duplicate, you expect the created product to be exactly the same.

@LouiseBonnard

LouiseBonnard commented Nov 23, 2020

Copy link
Copy Markdown
Contributor

I think it is the expected behavior and, in my opinion, we should keep it as-is. Duplicating the stock can mess everything up, even if duplicated products are disabled by default.

Nevertheless, I agree with @marionf: we can hardly predict the merchants' need regarding the stock of their duplicated products... that is why I believe the best scenario would be to allow it as an option, either in the Product Settings page or, even better, inside the modal window during the duplication process.

@MatShir

MatShir commented Nov 23, 2020

Copy link
Copy Markdown
Contributor Author

Ah, I like the idea of a pop-up or new parameters. What could be done also if none of the louise's suggestions can't fit into the migration project, is at least a warning message saying that all the fields including (or excepting) the stock are going to be duplicated.

Comment thread back-office/catalog/products/catalog-products-add-edit.md Outdated
Comment thread back-office/catalog/products/catalog-products-add-edit.md Outdated
@marionf

marionf commented Nov 23, 2020

Copy link
Copy Markdown
Contributor

Yes, I also like the idea of the option in the pop-up, I think it's more easier than in product settings since it could be different from one time to another

MatShir and others added 5 commits November 24, 2020 10:45
Co-authored-by: LouiseBonnard <32565890+LouiseBonnard@users.noreply.github.com>
Co-authored-by: LouiseBonnard <32565890+LouiseBonnard@users.noreply.github.com>
@MatShir

MatShir commented Jan 12, 2021

Copy link
Copy Markdown
Contributor Author

To get back on the subject, a long time ago, I was suggesting that the duplication of the SEO was not the best solution PrestaShop/PrestaShop#18529. As for the stock, should we do a proper duplication and notice the merchant the duplicated content?

@marionf marionf left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few suggestions

Comment thread back-office/catalog/products/catalog-products-add-edit.md Outdated
Comment thread back-office/catalog/products/catalog-products-add-edit.md Outdated
Comment thread back-office/catalog/products/catalog-products-add-edit.md Outdated
@marionf

marionf commented Jan 13, 2021

Copy link
Copy Markdown
Contributor

As for the stock, should we do a proper duplication and notice the merchant the duplicated content?

Maybe we can ask in a modal if he/she want to duplicate the SEO content before the duplication as for the stock ?
Or at least a warning

MatShir and others added 3 commits January 27, 2021 16:30
Co-authored-by: marionf <marionf@users.noreply.github.com>
Co-authored-by: marionf <marionf@users.noreply.github.com>
Co-authored-by: marionf <marionf@users.noreply.github.com>
@marionf marionf added Waiting for author Waiting for author feedback and removed WIP Work in progress labels Apr 8, 2021
@MatShir MatShir added Waiting for PM Waiting for PM review Waiting for QA Status: Action required, Waiting for test feedback and removed Waiting for PM Waiting for PM review Waiting for QA Status: Action required, Waiting for test feedback labels Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Waiting for author Waiting for author feedback

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants