Skip to content

Hide the shipping method for virtual product when the order summary is enabled - #209

Open
MatShir wants to merge 9 commits into
masterfrom
MatShir-order-summary-virtual-product
Open

Hide the shipping method for virtual product when the order summary is enabled#209
MatShir wants to merge 9 commits into
masterfrom
MatShir-order-summary-virtual-product

Conversation

@MatShir

@MatShir MatShir commented Mar 4, 2021

Copy link
Copy Markdown
Contributor
Questions Answers
Description? Hide the shipping method for virtual product when the order summary is enabled
Fixed ticket? PrestaShop/PrestaShop#8738

@MatShir MatShir added Review required Specifications to be reviewed Waiting for PM Waiting for PM review Waiting for QA Status: Action required, Waiting for test feedback labels Mar 4, 2021

@Robin-Fischer-PS Robin-Fischer-PS left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small suggestion, otherwise LGTM.

Comment thread front-office/checkout.md Outdated
Comment thread front-office/checkout.md Outdated
@Robin-Fischer-PS Robin-Fischer-PS added Waiting for author Waiting for author feedback and removed Waiting for QA Status: Action required, Waiting for test feedback labels Mar 10, 2021

@marionf marionf left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments @MatShir

Comment thread front-office/checkout.md Outdated
Comment thread front-office/checkout.md Outdated
Comment thread front-office/checkout.md Outdated
Comment thread front-office/checkout.md Outdated
@marionf marionf removed Review required Specifications to be reviewed Waiting for PM Waiting for PM review labels Mar 11, 2021
MatShir and others added 4 commits April 29, 2021 12:33
Co-authored-by: marionf <marionf@users.noreply.github.com>
Co-authored-by: marionf <marionf@users.noreply.github.com>
Co-authored-by: marionf <marionf@users.noreply.github.com>
Co-authored-by: marionf <marionf@users.noreply.github.com>
@MatShir MatShir added Review required Specifications to be reviewed and removed Waiting for author Waiting for author feedback labels Apr 29, 2021
@marionf

marionf commented Apr 29, 2021

Copy link
Copy Markdown
Contributor

@MatShir Could you fix the conflict ?

@marionf marionf added Waiting for author Waiting for author feedback and removed Review required Specifications to be reviewed labels Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Waiting for author Waiting for author feedback

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants