Skip to content

Add core weekly 7 of 2020 - #647

Merged
matks merged 5 commits into
PrestaShop:masterfrom
matks:core-weekly-7-2020
Feb 20, 2020
Merged

Add core weekly 7 of 2020#647
matks merged 5 commits into
PrestaShop:masterfrom
matks:core-weekly-7-2020

Conversation

@matks

@matks matks commented Feb 18, 2020

Copy link
Copy Markdown
Contributor

No description provided.


Dear developers,

Last week our Product Team had a wonderful surprise: they received a notification telling them someone opened a [Pull Request on the Specifications repository](https://github.com/PrestaShop/prestashop-specs/pull/86) ! They were delighted to see the community willing to collaborate on us on this project.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sam-pires @colinegin Please tell me if you agree with this 😉

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments @matks :

  • i'm not sure people are aware of this repo, so maybe we should give a few info about it
  • i'm not sure we should call it a "project"
  • maybe we could directly thank the contributor whose name is arouiadib

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All right, can you write what you'd like to say 😉 ?

I dont want to write something, then you provide feedback, then I write something, then you provide feedback ... 😅

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My proposition : "Last week our Product Team had a wonderful surprise: they received a notification telling them someone opened a Pull Request on the Specifications repository ! This is the first community contribution since this repo dedicated to centralize all core and module functional specifications has been created. They were delighted to see the community willing to collaborate with us on this huge work."

Wdyt @matks @sam-pires ?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
I'll quickly clean the repo tree we messed up with Gitbook, and add some guidelines on how to contribute.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you wait a bit before merging? 🙂 like a couple of hours

Comment thread news/_posts/core-weekly/2020-02-18-coreweekly-week-07-2020.md Outdated
Comment thread news/_posts/core-weekly/2020-02-18-coreweekly-week-07-2020.md Outdated
matks and others added 3 commits February 18, 2020 14:51
@sam-pires

Copy link
Copy Markdown
Contributor

Let's merge and publish this Core Weekly ! 🤞

merge

@matks
matks merged commit 0c0b317 into PrestaShop:master Feb 20, 2020
@matks

matks commented Feb 20, 2020

Copy link
Copy Markdown
Contributor Author

Thanks for review

@matks
matks deleted the core-weekly-7-2020 branch February 20, 2020 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants