Skip to content

Fix custom link label being double HTML-encoded on each save #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
boo-code wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Fix custom link label being double HTML-encoded on each save #90

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions ps_mainmenu.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1359,6 +1359,14 @@ public function getAddLinkFieldsValues()
$link['link'][$key] = Tools::htmlentitiesDecodeUTF8($label);
}

// Decode the label as well, the same way the link is decoded above. getLinkLang()
// returns it HTML-entity encoded (Tools::safeOutput), so without this the edit form
// pre-fills with the encoded value and re-encodes it on every save, stacking the
// entities (e.g. "À" -> "À" -> "À" -> ...).
foreach ($link['label'] as $key => $label) {
$link['label'][$key] = Tools::htmlentitiesDecodeUTF8($label);
}

$links_label_edit = $link['link'];
$labels_edit = $link['label'];
$new_window_edit = $link['new_window'];
Expand Down