Fix Workflow use actions/cache@v4 instead of V1 or V2 - #97
Merged
Conversation
|
Hello @Touxten! This is your first pull request on ps_shoppingcart repository of the PrestaShop project. Thank you, and welcome to this Open Source community! |
Member
|
ps_shoppingcart/ps_shoppingcart.php Line 104 in 8d1852f return array|CartLazyArray |
Touxten
marked this pull request as ready for review
July 21, 2025 08:33
Contributor
Author
|
Thx you @Hlavtox it's ok |
Touxten
marked this pull request as draft
July 21, 2025 09:46
Member
|
Aaaaargh, just delete the typehit. If we add use PrestaShop\PrestaShop\Adapter\Presenter\Cart\CartLazyArray;, it won't be available in older versions of prestshop and it will complain again or may not work. |
Touxten
marked this pull request as ready for review
July 21, 2025 13:07
nicosomb
approved these changes
Oct 7, 2025
|
Hello @Touxten, Thanks for your PR, CI are green ^^ |
SiraDIOP
approved these changes
Oct 9, 2025
Contributor
Author
|
Thank you @SiraDIOP |
github-project-automation
Bot
moved this from Ready for review
to Merged
in PR Dashboard
|
PR merged, well done! Message to @PrestaShop/committers: do not forget to milestone it before the merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.