Skip to content

Accept child-theme zips without explicit directory entries #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
boo-code wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Accept child-theme zips without explicit directory entries #72

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions controllers/admin/AdminPsThemeCustoAdvanced.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -419,9 +419,14 @@ public function processCheckZipFormat($sZipPath)

for ($i = 0; $i < $oZip->numFiles; ++$i) {
$aZipElement = array_filter(explode('/', $oZip->getNameIndex($i)));
if (count($aZipElement) == 1) {
$aRootFilesAndFolders[] = $aZipElement[0];
if (empty($aZipElement)) {
continue;
}
// Collect the first path segment of every entry. The "config" folder may be present
// only implicitly (e.g. "config/theme.yml") when the archive carries no explicit
// directory entries, so relying on a standalone "config/" entry rejected otherwise
// valid zips with "The file is not valid.".
$aRootFilesAndFolders[] = reset($aZipElement);
}

$oZip->close();
Expand Down