Skip to content

Minhal/NFTRWP-211 | Transactions updated automatically on sharing#296

Open
syed-primelab wants to merge 1 commit intodevfrom
minhal/NFTRWP-211
Open

Minhal/NFTRWP-211 | Transactions updated automatically on sharing#296
syed-primelab wants to merge 1 commit intodevfrom
minhal/NFTRWP-211

Conversation

@syed-primelab
Copy link
Copy Markdown
Contributor

No description provided.

@vercel
Copy link
Copy Markdown

vercel bot commented Jan 20, 2022

@syed-primelab is attempting to deploy a commit to the Nearapps Team on Vercel.

To accomplish this, @syed-primelab needs to request access to the Team.

Afterwards, an owner of the Team is required to accept their membership request.

If you're already a member of the respective Vercel Team, make sure that your Personal Vercel Account is connected to your GitHub account.

Copy link
Copy Markdown
Contributor

@biswanathsahoo biswanathsahoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't redirect the user to the history page by default because there no meaning of the success popup with a Open History button. The transactions are updating, the only problem is it is taking some time to load the data. It's better to add a loader to show the progress. And also, you can dispatch a event to to load the history from the server.

@syed-primelab
Copy link
Copy Markdown
Contributor Author

syed-primelab commented Jan 23, 2022

Hey @biswanathsahoo
The current working (on dev branch) is when transaction went successful, success pop shown along with button says "Open History". And when you click the button then it will call an API to fetch all transactions.

What I did (in this feature branch) is that after successful transaction, API called for fetching transactions right away and data also updated in no time. Moreover, on clicking "Open History" button, only dialog box closes.

In my opinion, after successful transaction, GET API should be called right away with loader and the modal should auto closed as user already notified via toast. So there will be no need of clicking "Open History" button.

Please guide what should be the flow?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants