fix(docker): refactor to multi-stage build (#89)#189
Open
Philzwrist07 wants to merge 1 commit into
Open
Conversation
- Add builder stage (rust:1.75-slim-bookworm) that compiles WASM - Add runtime stage (debian:bookworm-slim) that ships only *.wasm + Stellar CLI - Pin both base images to digest for reproducible builds - Update README with stage table and build commands
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #89 Resolves #89. The previous Dockerfile used a single stage, shipping the full Rust toolchain
(~1.5 GB) in the final image alongside the WASM artifacts. This PR splits the build into two
stages, reducing the final image to a minimal Debian base with only the compiled artifacts and
Stellar CLI.
Changes
Dockerfile
target, and compiles WASM binaries
Stellar CLI and nothing else
README
image (useful for CI)
Testing
Build runtime image (final artifact)
docker build --target runtime -t cosmosvote:latest .
Build builder image and run tests
docker build --target builder -t cosmosvote:builder .
docker run --rm cosmosvote:builder make test
Acceptance Criteria