fix(#36): add keyboard accessibility to ProposalDetail modal#195
Open
JosephOnuh wants to merge 1 commit into
Open
fix(#36): add keyboard accessibility to ProposalDetail modal#195JosephOnuh wants to merge 1 commit into
JosephOnuh wants to merge 1 commit into
Conversation
- Add Escape key handler to close modal - Implement native focus trap (Tab/Shift+Tab cycling) - Move focus to close button on open - Return focus to triggering ProposalCard on close - Add role="dialog", aria-modal="true", aria-labelledby - Add aria-label to close button - Pass triggerRef from App through ProposalCard click event
|
@JosephOnuh Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #36
Changes
role="dialog",aria-modal="true",aria-labelledbyto modal containeraria-labelto close buttontriggerReffrom App through ProposalCard click eventTesting