fix: zero-address guard + secrets manager guidance (#78, #74)#207
Open
Agnes432 wants to merge 1 commit into
Open
fix: zero-address guard + secrets manager guidance (#78, #74)#207Agnes432 wants to merge 1 commit into
Agnes432 wants to merge 1 commit into
Conversation
|
@Agnes432 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Closes PrincessnJoy#78 Closes PrincessnJoy#74 Issue PrincessnJoy#78: Add zero-address guard to transfer_admin in governance contract. Rejects the all-zeros Stellar account (GAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAWHF), returning ContractError::InvalidNewAdmin. Adds test_transfer_admin_zero_address_fails. Issue PrincessnJoy#74: Add docs/security/key-management.md covering HSM, AWS Secrets Manager, HashiCorp Vault, and key rotation. Update deploy scripts to auto-fetch STELLAR_SECRET_KEY from secrets manager. Strengthen .env.example warning.
Agnes432
force-pushed
the
fix/security-issues-78-74
branch
from
accb980 to
ac57540
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #78
Closes #74
fix: zero-address guard on transfer_admin + secrets manager guidance (#78, #74 )
Issue #78 — transfer_admin zero-address guard (security/bug)
transfer_admin had no validation on new_admin, meaning passing the all-zeros Stellar account
(GAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAWHF) — which has no valid keypair — would
permanently lock all admin functions.
Changes:
Issue #74 — Secrets manager guidance for STELLAR_SECRET_KEY (security/devops/docs)
STELLAR_SECRET_KEY was only documented as a .env variable with no guidance on secure handling for
production.
Changes:
integration, and key rotation procedure
(SECRETS_MANAGER_SECRET_ID) or HashiCorp Vault (VAULT_SECRET_PATH) when the env var is not set directly