Draft
Conversation
rlskoeser
commented
Mar 2, 2026
| # to avoid having to reconcile columns first | ||
| output_df = pl.concat([output_df, merged_output_df], how="diagonal") | ||
|
|
||
| # now identify & merge partial overlap |
Collaborator
Author
There was a problem hiding this comment.
@laurejt sorry for the confusing diff! I didn't recognize how many changes here. This is the part of the code I wanted your thoughts on
- new method to identify overlapping spans, with configurable overlap - new method to combine groups of ids - first-pass to refactor merge logic for use by exact and partial overlap - initial method to run all partial merge steps
rlskoeser
force-pushed
the
feature/merge-near-dupes
branch
from
e51dfaa to
c67fed2
Compare
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (25.00%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #257 +/- ##
===========================================
- Coverage 79.76% 78.93% -0.84%
===========================================
Files 23 23
Lines 2120 2150 +30
===========================================
+ Hits 1691 1697 +6
- Misses 429 453 +24 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Associated Issue(s): resolves #251
Changes in this PR
Notes