Merged
Conversation
- General translate method now uses underlying model defaults - General translate method now expects shortedn model identifiers - Updated translate_corpus script so it fails fast - Simplified tqdm progress bar logic
|
@laurejt The script runs without problems, and the document is sufficient and clear enough. Thank you for working on this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Associated Issue(s): None
Changes in this PR
translate.pyso that the correct / default HuggingFace models are used (earlier in development, we made the decision to work with the smaller sized hymt1.5 and madlad400 models.). Also updated the generic translate function so it uses model shorthand identifiers.translate_corpus.pyso it fails early (i.e., fails / halts on the first error encountered). Also simplifiedtqdmlogic.DEVELOPERNOTES.mdsetup to provide more details on the ADC file, especially when switching between projects.Reviewer Checklist
translate_corpus.pyruns successfully for both HuggingFace models and Google's TLLM