Script for building parallel paragraph corpus#47
Merged
Conversation
tanhaow
approved these changes
Mar 10, 2026
tanhaow
left a comment
There was a problem hiding this comment.
I tested the code and the output looks good. This branch is ready to merge.
|
|
||
| Yields parallel paragraph records | ||
| """ | ||
| count = 0 |
There was a problem hiding this comment.
Here the ID starts with 0, but the ID in build_sentence.py starts with 1. We may want to unify them.
Author
There was a problem hiding this comment.
Thanks for flagging this, I must have missed this when reviewing build_sentence, I did expect IDs to start at 0 since it's really serving as a index rather than a meaningfully unique identifier.
I find that 1-indexing always leads to trouble in 0-indexed languages.
Co-authored-by: Hao Tan <tanhao@princeton.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Associated Issue(s): resolves #41
Changes in this PR
Notes
Reviewer Checklist
build_paragraph.pyruns locally using the MTO-parallel-data files (expected input is a directory). Confirm that the local output matches mto-parallel-pars.jsonl