cutqc2 run command with optimizations#25
Merged
Merged
Conversation
…me we encounter it
… wrt qiskit-aes-gpu dep
Collaborator
Author
|
@Subashkatel - I'm done with this PR. Feel free to review and merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Major changes
cutqc2 runcommand (initiallycutqc2 cutdid an implicit run as well). This step is MPI capable.run_subcircuitsmethod inCutCircuitclass (multi-threading interferes with GPU execution and actually slows things down. MPI is a more scalable approach).config.yamlas well as environment variables. This may cause the CI to fail on Mac since it is enabled by default. This may need some tweaking in the CI workflows as well as a mention in the documentation. Additional dependencies have been introducedrequirements.txtfor this.EDIT: All the TODOs above have been attended to.
Overall, a 56x speedup even if just using a single MPI node.