Skip to content

auth failures talk too much #35

Description

@kaievns

when the signIn fails due to a wrong username or wrong password, the response error actually says either wrong username or wrong password.

this is a security vulnerability. firstly it tells the attacker that they've got the username right. and secondly it allows the attacker to check your system against existing email databases and know who's actually registered in the system.

the failure message should just say 'wrong username or password'. don't even mention 'email'

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions