fix(api): propagate database errors correctly with 500 status code#1884
Open
panditshubham766-dotcom wants to merge 2 commits into
Open
fix(api): propagate database errors correctly with 500 status code#1884panditshubham766-dotcom wants to merge 2 commits into
panditshubham766-dotcom wants to merge 2 commits into
Conversation
|
@panditshubham766-dotcom is attempting to deploy a commit to the PRIYANSHU DOSHI's projects Team on Vercel. A member of the Team first needs to authorize it. |
GSSoC Label Checklist 🏷️@Priyanshu-byte-coder — please apply the appropriate labels before merging: Difficulty (pick one):
Quality (optional):
Validation (required to score):
|
There was a problem hiding this comment.
Thanks for your first PR on DevTrack! 🎉
A maintainer will review it within 48 hours. While you wait:
- Make sure CI is passing (type-check + lint)
- Double-check the PR description is filled out and the issue is linked
- Feel free to ask questions in Discussions if you need help
If you find DevTrack useful, a ⭐ star on the repo is always appreciated — it helps the project grow and attract more contributors!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed a critical backend issue where several API routes were catching database/query failures but hiding them by returning a
200 OKstatus with empty fallback data. Unhandled exceptions now correctly propagate as a500 Internal Server Errorto prevent the frontend from misinterpreting database failures as successful empty responses.Closes #1792
Type of Change
Changes Made
200error-masking blocks with properNextResponse.jsonerror payloads containing a500status code.200empty states (like empty pins data or unconfigured profiles) so normal application behavior remains uninterrupted.How to Test
/api/local-coding/stats).500 Internal Server Errorpayload instead of a fake200 OK.