Repository navigation
Linux builds on Ubuntu 22.04; fix statistics never being sent - #7
Merged
Merged
Conversation
In 0.3.0 the stats thread called block_on on the reqwest future from a plain thread; reqwest needs a Tokio reactor, so the thread panicked with "no reactor running" and no launch or heartbeat ever reached the hub. The request now runs as a task of Tauri's runtime and the thread only waits for it. Verified in an Ubuntu 22.04 container: offline, the app logs "error sending request" and keeps running. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A program needs a glibc no newer than the one it was built against; the 24.04 build required glibc 2.39 and failed the AppImage catalog test, which runs on the oldest supported LTS. The pipewire crate (via xcap) needs PipeWire 1.x headers, so they come from the pipewire-upstream PPA, for compiling only: the binary does not load libpipewire. Checked in a container: the 22.04 AppImage needs at most GLIBC_2.34 and starts on a clean 22.04 without network. Smoke tests run on 22.04 and 24.04. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
launch/heartbeatevents.What
stats.rs: the request runs as a task of Tauri's async runtime; the thread only waits for it.ubuntu-22.04. Thepipewirecrate (via xcap) needs PipeWire 1.x headers, so they come fromppa:pipewire-debian/pipewire-upstream— for compiling only, the binary does not link or load libpipewire.[0.3.1].Checked
libspa; with the PPA (1.0.7) it builds.GLIBC_2.34and has nolibpipewiredependency.npm run check,npm test,cargo fmt --check,cargo clippy --all-targets -D warnings,cargo test— clean.Note
Changing
smoke.ymlruns the smoke test on this PR against the latest published release (0.3.0). Smoke (Linux 22.04) is expected to fail here — 0.3.0 was built on 24.04, which is exactly what this PR fixes. It should pass for 0.3.1.🤖 Generated with Claude Code