-
Notifications
You must be signed in to change notification settings - Fork 0
Small quality of life improvements #171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lolman420
wants to merge
4
commits into
main
Choose a base branch
from
daniel-dev
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
7421497
added disable to player create button after it has been pressed
lolman420 ec2fb97
made the text black in the player search input box
lolman420 2f4ecfe
redid search logic so it is now more logical
lolman420 e64923e
added search by ID and fixed bugs, refactored; also redid the logic c…
lolman420 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -128,23 +128,41 @@ const searchPlayers = async ( | |
| query: string, | ||
| limit?: number, | ||
| ): Promise<PlayerModel[]> => { | ||
| const colOptions = ["first_name", "last_name", "nickname", "id"]; | ||
| const permutations = permutator(colOptions); | ||
|
|
||
| const options = permutations.map((perm) => { | ||
| return Sequelize.where( | ||
| Sequelize.fn("concat", ...perm.map((col) => Sequelize.col(col))), | ||
| { | ||
| [Op.iLike]: `%${query.replaceAll(" ", "%")}%`, | ||
| }, | ||
| try { | ||
| const colOptions = ["first_name", "last_name", "nickname", "id"]; | ||
| const permutations = permutator(colOptions); | ||
|
|
||
| const queryParts = query.split(" ").filter((part) => part.length > 0); | ||
|
|
||
| const options = await Promise.all( | ||
| queryParts.map(async (part) => { | ||
| return await Promise.all( | ||
| permutations.map(async (perm) => { | ||
|
Comment on lines
+137
to
+140
|
||
| return Sequelize.where( | ||
| Sequelize.fn("concat", ...perm.map((col) => Sequelize.col(col))), | ||
| { | ||
| [Op.iLike]: `${part}%`, | ||
| }, | ||
| ); | ||
| }), | ||
| ); | ||
| }), | ||
| ); | ||
| }); | ||
|
|
||
| const players = await PlayerModel.findAll({ | ||
| where: { [Op.or]: options }, | ||
| limit: limit, | ||
| }); | ||
| return players; | ||
| const whereClause = { | ||
| [Op.and]: options.map((opts) => ({ [Op.or]: opts })), | ||
| }; | ||
|
|
||
| const players = await PlayerModel.findAll({ | ||
| where: whereClause, | ||
| limit: limit, | ||
| }); | ||
|
|
||
| return players; | ||
| } catch (error) { | ||
| console.error("Error in searchPlayers:", error); | ||
| throw error; | ||
| } | ||
| }; | ||
|
|
||
| export { | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This toggle logic is incorrect. The button should be disabled during submission and re-enabled after completion. This should be
setButtonPressed(true)at the start of submission andsetButtonPressed(false)after the request completes (both success and error cases).