Skip to content

Exit modal on outside click #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kallishuone merged 1 commit into from
Nov 17, 2025
Merged

Exit modal on outside click #29

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions frontend/src/components/ApplicationModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,11 @@ function Modal({ isOpen, onClose, children }: ModalProps) {

if (!isOpen) return null
return (
<div className="fixed inset-0 z-50 bg-black bg-opacity-50 overflow-auto">
<div className="fixed inset-0 z-50 bg-black bg-opacity-50 overflow-auto"
onClick={onClose}>
{/* Add max-h-full to prevent exceeding viewport and enable scrolling */}
<div className="bg-white rounded-lg p-6 shadow-lg relative mx-auto my-8 w-full max-w-2xl max-h-[90vh] overflow-y-auto">
<div className="bg-white rounded-lg p-6 shadow-lg relative mx-auto my-8 w-full max-w-2xl max-h-[90vh] overflow-y-auto"
onClick={(e) => e.stopPropagation()}>
{/* Close button inside the modal */}
<button
onClick={onClose}
Expand Down