Repository navigation
Fix Live TV search selection on Fire TV - #792
Merged
Merged
Conversation
github-actions
Bot
added
the
area: android
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Live TV search results used a custom key/tap handler without a standard click action. NumPad Enter was ignored, and activating on key-down could leave the Select release for the underlying guide after search closed.
Use Compose click handling for remote Select, Enter variants, touch and accessibility activation. Keep focus within the search panel, dismiss the keyboard when entering results, and reveal the first result before focusing it. Retain the selected channel object so paged search matches can start playback directly, and clear any previous catch-up state.
Validation: sideload debug and instrumentation APKs build successfully. Eight selection/navigation checks passed in three consecutive runs on a 2 GB Android TV emulator using injected Android key events and synthetic channel/programme data. Coverage includes remote Select, Enter variants, programme matches, paged-provider results, scrolling, touch, accessibility and closing search without leaking the Select release into the guide. Remote checks isolate the system keyboard; the IME Search callback is exercised separately. Baseline checks confirmed ignored NumPad Enter; ordinary DPAD Select already worked in the emulator. Physical Fire TV hardware and provider playback were not tested.