Repository navigation
Search: recent searches, clear button, and encoded addon search URLs - #800
Merged
Merged
Conversation
- Recent searches: the profile's last 8 queries, shown as a chip row under the search bar while it is empty. A query is kept on submit or when a result is opened, and only if it found something. One "Clear" chip removes them all; the row has its own D-pad stop between the search bar and the filters. - The search bar shows a clear button while it holds a query (D-pad toward its end, or tap on touch). - Addon catalog search encodes the catalog type and id like the other catalog URLs, so types such as "Live Docs" are no longer sent raw.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Search had no memory: every query had to be typed again with the remote keyboard, and once a query was in the bar there was no quick way to empty it. Separately, addon catalog search sent the catalog type and id unencoded, unlike every other catalog URL, so addons with types such as
Live Docsgot a broken request.What changed
Testing