Skip to content

Fix menu bar temperature width jitter - #51

Open
jiiim wants to merge 1 commit into
ProducerGuy:mainfrom
jiiim:fix/menu-bar-temperature-jitter
Open

jiiim wants to merge 1 commit into
ProducerGuy:mainfrom
jiiim:fix/menu-bar-temperature-jitter

Conversation

@jiiim

@jiiim jiiim commented Sep 18, 2026 •

Copy link
Copy Markdown

The menu bar item changes width as temperature digits update because MenuBarExtra does not reliably preserve the fixed-pitch label layout.

Replace the MenuBarExtra presentation with a retained NSStatusItem and NSPopover. The status icon and temperature are rendered as one image with a fixed-width, three-column temperature field.

This also:

  • preserves the active, idle, and safety icon states
  • preserves the daemon-version warning badge
  • adapts the composite image to the current appearance
  • avoids redundant status-item layout updates
  • prevents a transient popover from reopening on the click that closes it
  • retains the existing MenuBarView and AppState

Validation:

  • swift build
  • swift test — 152 tests passed

@jiiim

jiiim commented Oct 7, 2026

Copy link
Copy Markdown
Author

@ProducerGuy Rebased on latest main and re-verified — build green, all 152 tests pass. Would love to see this merged; let me know if any adjustments are needed.

@ProducerGuy

Copy link
Copy Markdown
Owner

@jiiim already on it. Yours is coming with a big update. Messed my wrist up so slower than I wanted. Found some other issues that tied in.

@jiiim
jiiim force-pushed the fix/menu-bar-temperature-jitter branch 3 times, most recently from 05cb1ff to fa9271b Compare October 7, 2026 19:53
MenuBarExtra ignores fixed-pitch label styling, so the status item
width changes as temperature digits update. Render a native
NSStatusItem with a fixed-width temperature field and host the
existing menu in a popover.
@jiiim
jiiim force-pushed the fix/menu-bar-temperature-jitter branch from fa9271b to 31b0d92 Compare October 7, 2026 19:56
@jiiim

jiiim commented Oct 7, 2026 •

Copy link
Copy Markdown
Author

@jiiim already on it. Yours is coming with a big update. Messed my wrist up so slower than I wanted. Found some other issues that tied in.

@ProducerGuy Thanks. I do have a late fix I force-pushed to the PR today, right after your reply here. You'll want that. :)

And thanks for ThermalForge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants