Repository navigation
Conversation
jiiim
force-pushed
the
fix/menu-bar-temperature-jitter
branch
from
October 7, 2026 19:28
d5a8d77 to
0cb4fa6
Compare
Author
|
@ProducerGuy Rebased on latest main and re-verified — build green, all 152 tests pass. Would love to see this merged; let me know if any adjustments are needed. |
Owner
|
@jiiim already on it. Yours is coming with a big update. Messed my wrist up so slower than I wanted. Found some other issues that tied in. |
jiiim
force-pushed
the
fix/menu-bar-temperature-jitter
branch
3 times, most recently
from
October 7, 2026 19:53
05cb1ff to
fa9271b
Compare
MenuBarExtra ignores fixed-pitch label styling, so the status item width changes as temperature digits update. Render a native NSStatusItem with a fixed-width temperature field and host the existing menu in a popover.
jiiim
force-pushed
the
fix/menu-bar-temperature-jitter
branch
from
October 7, 2026 19:56
fa9271b to
31b0d92
Compare
Author
@ProducerGuy Thanks. I do have a late fix I force-pushed to the PR today, right after your reply here. You'll want that. :) And thanks for ThermalForge! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The menu bar item changes width as temperature digits update because
MenuBarExtradoes not reliably preserve the fixed-pitch label layout.Replace the
MenuBarExtrapresentation with a retainedNSStatusItemandNSPopover. The status icon and temperature are rendered as one image with a fixed-width, three-column temperature field.This also:
MenuBarViewandAppStateValidation:
swift buildswift test— 152 tests passed