Repository navigation
Conversation
… below-stopTemp tick The peak sensor is a max over all CPU/GPU cores, and an idle core's reading drops 20-30°C the instant its workload ends. With stopTemp at idle-core resting level the peak oscillates across the threshold on a 100ms scale, and the instant "Fans off" release hands the fans to Apple mid-ramp over and over — in three days of logs: 2,182 releases, fans slamming 3000+→1300 RPM every 3-7 seconds (start/stop cycling is the ProducerGuy#1 bearing wear factor). New FanOffGate (pure decision logic, hardware-free): releasing to Apple auto now requires the peak to stay at/below stopTemp for FanProfile.stopSustainSeconds (5s); a warm tick anywhere in the window restarts the streak. Until cold is confirmed, fans hold at minimum RPM — the same treatment the hysteresis band already gives — so a dip-and-recover never stops the fans. Six behavior regressions in FanOffGateTests.
iBobbyTS
force-pushed
the
fix/fanoff-sustained-cold
branch
from
October 20, 2026 18:45
45fefaa to
1cb3235
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The peak sensor is a max over all CPU/GPU cores, and an idle core's reading drops 20-30°C the instant its workload ends. With stopTemp at idle-core resting level the peak oscillates across the threshold on a 100ms scale, and the instant "Fans off" release (
temp <= stopTemp && fansCurrentlyRunning → resetAuto) hands the fans to Apple mid-ramp over and over. Measured on this hardware over three days of logs: 2,182 releases, fans slamming 3000+→1300 RPM every 3-7 seconds — start/stop cycling is the #1 bearing wear factor.Fix
New
FanOffGate(pure decision logic, hardware-free): releasing to Apple auto now requires the peak to stay at/below stopTemp forFanProfile.stopSustainSeconds(5s); a warm tick anywhere in the window restarts the streak. Until cold is confirmed, fans hold at minimum RPM — the same treatment the hysteresis band already gives (the existing0.001minimum signal), so a dip-and-recover never stops the fans. The start-sidesustainedTriggerSecbehavior is untouched.Testing
swift build+ fullswift testpass, including six new behavior regressions inFanOffGateTests(momentary dip holds minimum, release exactly at the window, warm tick restarts the streak, post-release re-earn, inclusive threshold, window mirrors FanProfile).