-
Notifications
You must be signed in to change notification settings - Fork 1
댓글/대댓글 작성, 조회 API #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pingu9
wants to merge
14
commits into
main
Choose a base branch
from
feat-dj-comments-and-reply
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheolwon1994
reviewed
Oct 5, 2023
Contributor
cheolwon1994
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
전반적으로 잘 작성하셨지만 크게 2가지에 대한 수정사항이 있을것 같아요!
- 전략적 패턴을 이용한 Command.run() / execute() 처리
- xxxCommandExecutor의 경우 REST HTTP Method별 구분이 아닌, xxx를 활용한 처리가 이뤄져야 합니다!
ex) CommentCommandExecutor{
// getComment
// postComment
}
src/main/java/com/catcher/core/domain/response/GetCommentsByPageResponse.java
Show resolved
Hide resolved
Contributor
Author
10/6 |
Merged
댓글 작성 기능 - 커맨드 패턴 처리 개선
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
swit 링크: https://app.swit.io/share-route?route_type=project&route_variables=23091405520180SZFQIM%2C23091405572194IM56Q6%2C23100104142117E7UMN3%2C
우선 주어진 보일러플레이트 기반으로 댓글, 대댓글을 작성하는 API, 테스트 코드를 간단히 작성해 보았습니다. (조회 API 테스트는 아직 작성중인데 우선 기능 먼저 올립니다.) 구체적인 기획이 나오지 않은 상태라 큰 의미는 없겠지만 이런 스타일로 코딩하고 있다.. 정도만 나누는 의미일 듯 합니다.