Phoenix 2026 spi fix#21
Merged
TimoWielink merged 3 commits intoJul 7, 2026
Merged
Conversation
Signed-off-by: TimoWielink <timowielink@gmail.com>
Signed-off-by: TimoWielink <timowielink@gmail.com>
faradaym
reviewed
Jul 7, 2026
| Duid getOrigin(){ | ||
| Duid originDuid; | ||
| std::copy(origin.begin(), origin.end(), originDuid.begin()); | ||
| originDuid.fill(0); |
There was a problem hiding this comment.
change this and getDestination to an optional
faradaym
reviewed
Jul 7, 2026
| logdbg_ln("RREQ: %s", log.c_str()); | ||
|
|
||
| const std::string& last = objPath[objPath.size()-1]; | ||
| if (last.size() != DUID_LENGTH) { |
There was a problem hiding this comment.
validation should happen within a new class for Duid
faradaym
reviewed
Jul 7, 2026
| logerr_ln("RouteJSON missing origin/destination"); | ||
| return; | ||
| } | ||
| origin = originPtr; |
There was a problem hiding this comment.
answer: std::string has an overload for char* (fo c_str) and char* is null terminated so the length doesn't need to be declared
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validate Route Packets
Battery Command Float Conversion
SPI Fix