Conversation
Add a GitHub Actions workflow to run `nix flake check` on push and pull request to main. Refactor `crane.nix` to return build arguments instead of a derivation, allowing `flake.nix` to define separate checks for the package build, clippy, and rustfmt. Include an AppArmor fix in the CI workflow to support Bubblewrap on Ubuntu runners. Co-authored-by: ProjectInitiative <6314611+ProjectInitiative@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Update `flake.nix` to use `craneLib.buildDepsOnly` to build `cargoArtifacts` first. Pass `cargoArtifacts` to `craneLib.buildPackage` (for the main build) and `craneLib.cargoClippy` (for the clippy check). This fixes the CI error where `cargoClippy` was missing the required `cargoArtifacts` argument. Co-authored-by: ProjectInitiative <6314611+ProjectInitiative@users.noreply.github.com>
Run `cargo fmt` to fix code style issues in `src/s3_uploader.rs`. This is required to pass the `cargo fmt` check in CI. Co-authored-by: ProjectInitiative <6314611+ProjectInitiative@users.noreply.github.com>
Fix `clippy::manual_strip` warning in `src/s3_uploader.rs`. This is required to pass the `cargo clippy --deny warnings` check in CI. Co-authored-by: ProjectInitiative <6314611+ProjectInitiative@users.noreply.github.com>
|
please fix the build error: error: builder for '/nix/store/ky46d7rndy225d49zr6a2n7hm54067a9-loft-fmt-0.2.0.drv' failed with exit code 1; |
I've fixed the formatting issue in |
Reformat the `if let` expression in `src/s3_uploader.rs` to match the expected style required by `cargo fmt`. This resolves the build failure in the CI formatting check. Co-authored-by: ProjectInitiative <6314611+ProjectInitiative@users.noreply.github.com>
|
building '/nix/store/z1l4fyy86545yj8ky5vgcfjy90gc9b06-loft-0.2.0.drv'... |
I've fixed the |
Resolve `clippy::let_underscore_future` warnings in `src/nix_utils.rs` by correctly awaiting the `sleep` calls instead of ignoring the future. This is required to pass the CI clippy check. Co-authored-by: ProjectInitiative <6314611+ProjectInitiative@users.noreply.github.com>
This PR adds a CI workflow to the project.
It refactors
crane.nixto expose the build configuration, which is then used inflake.nixto definechecksfor:The CI workflow runs
nix flake checkto execute these checks. It also includes a necessary AppArmor configuration step for Nix sandboxing on Ubuntu runners.PR created automatically by Jules for task 818934876918795744 started by @ProjectInitiative