Add minimumDistance and maximumDistance functionality to GridSpawnGroup#678
Open
NotActuallyMarty wants to merge 2 commits intoProjectOmu:masterfrom
Open
Add minimumDistance and maximumDistance functionality to GridSpawnGroup#678NotActuallyMarty wants to merge 2 commits intoProjectOmu:masterfrom
NotActuallyMarty wants to merge 2 commits intoProjectOmu:masterfrom
Conversation
github-actions
bot
added
the
S: Untriaged
JustOrdinaryPao
added
Type: Enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the PR
Fails wanted to change ATS spawn distance for whatever reason and then i find out that despite GridSpawn has the parameters it is not actually implemented.
Crazy. If this isn't in upstream i'll PR something cleaner there later.
Why / Balance
Technical details
Steals the code from the way dungeons spawn at a random clamped minimum and max distance and i've put it in omumod just so i dont have to put all that shit in core.
Youl need to uncomment the yaml to test this PR. DO test it cause i thought i saw it generating dungeons at a point but didn't check and could just be a fluke. Really. Actually pull up your dev and test this cause i'm heading off got stuff to do but can't be bothered rn.
Media
Using these parameters:
Requirements
None changelog not player facing but PRs that do edit the spawn distanced of grids and stuff like ATS should actually put that in their changelog.