Porting over Floof/pirate layering system to fix tail clipping#695
Open
Kingofblades47 wants to merge 6 commits intoProjectOmu:masterfrom
Open
Porting over Floof/pirate layering system to fix tail clipping#695Kingofblades47 wants to merge 6 commits intoProjectOmu:masterfrom
Kingofblades47 wants to merge 6 commits intoProjectOmu:masterfrom
Conversation
github-actions
bot
added
S: Untriaged
Contributor
|
RSI Diff Bot; head commit 31f87b6 merging into 22d66f5 Resources/Textures/_DV/Mobs/Customization/Vulpkanin/tail_markings.rsi
|
JustOrdinaryPao
added
Bug: Large
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the PR
Ported over Floof's marking layering system along with some changes made by Pirate station which is a goob branch. Applied system to current Vulpkanin and the tails I saw with the issue to show proof of concept.
Why / Balance
To fix the look of pixels clipping through skirts from tails.
Technical details
Heavily modifies ApplyMarking in HumanoidAppearanceSystems.
Adds two DataFields into MarkingPrototype to be used in the makrings yaml files for layering and colorlinks.
Adds a check in MarkingPicker to see if two markings are attached via ColorLinks and if so copy the main's color onto the child's.
Setup baseline tail infront of body and behind for the species that I saw and were compatable.
Modified Vulpkanin markings yml and uploaded corrected marking images to work as proof of concept since doing all species and all tails at once is going to be a slog.
Media
Requirements
Breaking changes
It all but replaces the function in Humanoid Appearance Systems, so if something is an issue it would be a connection in there probably.
Changelog
🆑
Added floof marking system
Updated noticable Vulp tails to show it works