Repository navigation
Conversation
Collaborator
|
Thanks! All three guides now say Node 22, matching engines.node. Recreated in our internal monorepo in ProjectOpenSea/opensea-devtools#789 (now merged) with you credited, and it ships with the next SDK release. This repo is a read-only mirror, so we can't merge here, but we review every PR. Appreciate you taking the time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Three docs still require Node 20:
developerDocs/quick-start.md:14— "Node.js version 20 or higher is required… runnvm use 20"developerDocs/contributing.md:18— "Node.js 20 or higher"developerDocs/overview.md:32— "Node.js 20 or higher"Every other source in the repo says 22+:
package.jsonsetsengines.node: ">=22.0.0",README.md:287says "Node 22 or newer",AGENTS.mdsays "Node 22+ is the floor",developerDocs/stream-migration.md:156states "Node 22 is the minimum",CHANGELOG.md:505records the bump, and.nvmrc(which CI reads) is24.14.1.Impact
A reader following the Quick Start runs
nvm use 20, getsEBADENGINEfrom npm, and on that runtime@opensea/sdk/streamthrowsNo WebSocket implementation foundbecause Node 20 has no globalWebSocket. Contributors also set up a Node version that differs from CI.Fix
Update the three stale statements to 22, matching
engines.node. Prose only — no TypeScript fences changed, so the doc-example check is unaffected and biome (which covers**/*.ts,**/*.js,**/*.jsononly) does not touch markdown.