Skip to content

docs: correct misleading comments on Avalanche offer token - #2026

Closed
qsysvcore wants to merge 1 commit into
ProjectOpenSea:mainfrom
qsysvcore:fix/misleading-comments-chain-and-holders-args
Closed

qsysvcore wants to merge 1 commit into
ProjectOpenSea:mainfrom
qsysvcore:fix/misleading-comments-chain-and-holders-args

Conversation

@qsysvcore

Copy link
Copy Markdown

Summary

getOfferPaymentToken labels Avalanche's 0xB31f66AA…66c7 as // WETH. It
is WAVAX. The label was copy-pasted from the Chain.Polygon case directly
above it.

Both now name the right thing.

Why the first one is worth fixing

getListingPaymentToken, ~100 lines above, already labels the same address
// WAVAX, and test/utils/chain.spec.ts calls it "returns WAVAX for
Avalanche"
for this very function. The comment was the only statement in the
file asserting the wrong token.

Scope

Comments only — no behaviour, no types, no signatures. Nothing here needs a new
test: the underlying behaviour is already pinned by
test/utils/chain.spec.ts (the Avalanche address) and by check-types
(the ownedBy field name).

@ryanio

ryanio commented Oct 6, 2026

Copy link
Copy Markdown
Collaborator

Thanks, the label fix is right and is recreated in ProjectOpenSea/opensea-devtools#789 (now merged) with you credited.

One correction so the record matches the diff: the changed line is in getListingPaymentToken, while getOfferPaymentToken already said WAVAX. The ownedBy change mentioned in the description isn't in this PR's diff, so nothing was taken for it.

This repo is a read-only mirror, so we can't merge here, but we review every PR.

@ryanio ryanio closed this Oct 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants